perf(system): reduce pan-on-scroll gesture work - #5884
Open
AlaricBaraou wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 269b7f1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
panOnScrollis enabled, wheel gestures previously repeated avoidable native work on every event:pointer, which read the pane's bounding rect on every ctrl-wheel tick;scaleTo, making xyflow clear and recreate its trailingonPanZoomEndtimer on every tick;This change caches the pane origin for each 150 ms pinch gesture and coalesces both end paths with deadline-based trailing timers. The latest event and viewport are still delivered once, 150 ms after the final tick. D3 end state remains private per pan/zoom instance in a
WeakMap.Measurement
Call-count probes over the real handlers produced:
A timer wakes and re-arms against the latest deadline during a long gesture. Pointer coordinates and the final viewport were unchanged, and a new gesture after the idle window gets a fresh timer and remeasures the pane origin.
This was motivated by a production profile where the pinch path's repeated pane reads and timer churn accounted for about 308 ms of main-thread self time across a slow zoom gesture. The direct pan timer improvement is a follow-up found during downstream review; it was not part of that 308 ms measurement.
Validation
pnpm --filter @xyflow/system typecheckpnpm --filter @xyflow/system buildThe package-wide lint command also reports two existing
no-unnecessary-type-assertionerrors insrc/utils/edges/positions.tson unmodified main.