Expose MethodRouter call_with_state - #3860
Conversation
|
Hi, I’ve implemented the requested change by exposing I also verified the change with the relevant test, which passes successfully. Thank you for reviewing! |
|
Could you link the issue where the change was requested please? Also, I don't think the test actually tests what you say. It's a submodule so the visibility is not tested at all and the test itself is named as if it is supposed to test that this works with shared reference, but if the method required an owned object, I think it would still pass. Also next time, you should write any information you want to share about the PR in the description (including motivation and the issue link) not into comments. It's better visible for anyone seeing the PR. |
Motivation
Solution