Fix addList function to include type in API request URL - #3620
Merged
Conversation
Signed-off-by: Adam Warner <[email protected]>
rdwebdesign
approved these changes
Oct 4, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
The web interface was sending POST requests to /api/lists with the list type specified only in the JSON payload:
{ "address": ["example.com"], "type": "block", "groups": [0] }However, the FTL API expects the type to be specified as a URL query parameter for the generic /api/lists endpoint, not in the payload. This caused requests to fail with the error: "Specify type parameter (should be either 'allow' or 'block')".
Fixes an issue reported on Discourse: https://discourse.pi-hole.net/t/blocklist-error-on-qnap-container/82625
By submitting this pull request, I confirm the following:
git rebase)