messages: fix function call - #3482
Merged
Merged
Conversation
Signed-off-by: XhmikosR <[email protected]>
Member
Easiest is probably to add non-existing URLs for blocklists and run gravity. It should a message for each non-existing URL. |
yubiuser
approved these changes
May 23, 2025
yubiuser
left a comment
Member
There was a problem hiding this comment.
This was surly intended to be an function call.
Contributor
Author
|
I'm pretty sure (99.999 %) the previous code is wrong because it referenced
the function and didn't actually call it.
So the question is what the intention was here and if this call can be
dropped if it's not needed. Otherwise the patch is fine and actually fixes
the code.
…On Fri, May 23, 2025, 09:59 yubiuser ***@***.***> wrote:
*yubiuser* left a comment (pi-hole/web#3482)
<#3482 (comment)>
Is there any way to generate messages for testing?
Easiest is probably to add non-existing URLs for blocklists and run
gravity. It should a message for each non-existing URL.
—
Reply to this email directly, view it on GitHub
<#3482 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACVLNK6FMUJ5J2YO5IVE2D273BM7AVCNFSM6AAAAAB5WPNFXOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMBTGQ3DINRRGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Member
|
The idea is to update the message counter after users deleted some messages. |
Contributor
Author
|
Then we are good 👍
…On Fri, May 23, 2025, 10:06 yubiuser ***@***.***> wrote:
*yubiuser* left a comment (pi-hole/web#3482)
<#3482 (comment)>
The idea is to update the message counter after users deleted some
messages.
—
Reply to this email directly, view it on GitHub
<#3482 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACVLNO6KWMB7TZB52SYXC3273CIPAVCNFSM6AAAAAB5WPNFXOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMBTGQ4DAMZTGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I assume this was supposed to be a function call but I can't test it consistently. Is there any way to generate messages for testing?
Thank you for your contribution to the Pi-hole Community!
Please read the comments below to help us consider your Pull Request.
We are all volunteers and completing the process outlined will help us review your commits quicker.
Please make sure you
What does this PR aim to accomplish?:
How does this PR accomplish the above?:
Link documentation PRs if any are needed to support this PR:
By submitting this pull request, I confirm the following:
git rebase)