Skip video poster seek when ffprobe reports no numeric duration - #2570
Open
SAY-5 wants to merge 1 commit into
Open
Skip video poster seek when ffprobe reports no numeric duration#2570SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Signed-off-by: Sai Asish Y <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2567.
When a video has no duration metadata (for example a webm captured from a stream),
ffprobe -show_entries format=durationprintsN/Ainstead of a number. The guard inget_ffmpeg_video_thumb()only checks!empty($O[0]), soN/Apasses andfloor($O[0]*10)evaluates"N/A" * 10, which is a fatalUnsupported operand typeson PHP 8. The upload then silently fails with no gallery entry.This adds an
is_numeric()check so a non-numeric duration falls through to the existing$second = 0default, matching the reporter's own diagnosis in the issue.